vm: avoid stack overflow on recursive accessor calls#4699
Open
Flamki wants to merge 2 commits intoboa-dev:mainfrom
Open
vm: avoid stack overflow on recursive accessor calls#4699Flamki wants to merge 2 commits intoboa-dev:mainfrom
Flamki wants to merge 2 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Fixed tests (8): |
430081c to
9966682
Compare
Author
|
Follow-up hardening pushed in 9966682. What I changed:
ecursion_in_setter_throws_uncatchable_error
This complements the existing async-generator getter regression and ensures both accessor call directions are covered by runtime-limit behavior. |
Member
|
I'd suggest measuring the performance impact of this change, because keeping track of recursive native calls sounds like it could be detrimental for perf. You can use https://github.com/boa-dev/data/blob/main/bench/bench-v8/combined.js for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #4535.
Summary
Notes