Skip to content

fix bug: bounds are calculated incorrectly when scale is setting #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bug: bounds are calculated incorrectly when scale is setting #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,15 +341,15 @@ export class Rnd extends React.PureComponent<Props, State> {
const parentLeft = parentRect.left;
const parentTop = parentRect.top;
const left = (boundaryLeft - parentLeft) / scale;
const top = boundaryTop - parentTop;
const top = boundaryTop - parentTop / scale;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it needed to add paren?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes，it should be const top = (boundaryTop - parentTop) / scale;

if (!this.resizable) return;
this.updateOffsetFromParent();
const offset = this.offsetFromParent;
this.setState({
bounds: {
top: top - offset.top,
top: top - offset.top / scale,
right: left + (boundary.offsetWidth - this.resizable.size.width) - offset.left / scale,
bottom: top + (boundary.offsetHeight - this.resizable.size.height) - offset.top,
bottom: top + (boundary.offsetHeight - this.resizable.size.height) - offset.top / scale,
left: left - offset.left / scale,
},
});
Expand Down