feat: add single zone configuration #509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, there was no way to set up a specific zone for EC2 instance. This feature allows configuring a specific zone in Test.toml for a certain variant when launching its EC2 instance(s). Even though a minimum of two zones are needed when creating an EKS cluster, after the cluster is created this feature can limit one specific zone before launching the EC2 instances.
yeazelm
reviewed
Mar 18, 2025
| instance_type: Option<String>, | ||
|
|
||
| /// Specify the zone that should be used. This is only applicable for aws-* variants. | ||
| /// It can be omitted for non-aws variants and can be omitted to use default instance types. |
There was a problem hiding this comment.
Suggested change
| /// It can be omitted for non-aws variants and can be omitted to use default instance types. | |
| /// It can be omitted for non-aws variants and can be omitted to use default availability zones for the vpc. |
Is this what you meant?
|
|
||
| /// Specify the zone that should be used. This is only applicable for aws-* variants. | ||
| /// It can be omitted for non-aws variants and can be omitted to use default instance types. | ||
| #[arg(long, env = "TESTSYS_ZONES")] |
There was a problem hiding this comment.
Is the intention that we would specify this as TESTSYS_ZONES? I figured this would just be availability zones specific? Can you share how this is intended to be used as an example in the description?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Description of changes:
Added feature allows configuring a specific zone in Test.toml, so that EC2 instance(s) can be launched in this specific zone. Usually, two zones must specified, but this feature allows one specific single zone for EC2 instance to launch into.
Testing done:
See testing at: bottlerocket-os/bottlerocket-test-system#984
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.