✨ Add automatic dark/light mode support for topology views #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎯 Key Features: - Topology background automatically matches VSCode theme (dark/light) - No manual configuration required - works out of the box - Supports both light and dark themes seamlessly 🔧 Technical Implementation: - Embedded targeted CSS overrides in webview HTML (extension.ts) - Added CSP font-src policy for PatternFly font loading - Fixed webview.js build process in package.json - Cleaned up experimental code and false-positive tests 🧪 Testing & Quality: - Added dark-mode-validation.test.ts for regression prevention - All 113 tests passing (104 renderer + 9 extension) - Removed false-positive background regression test - Clean, minimal implementation with no leftover experimental code 🐛 Bug Fixes: - Fixed missing webview.js file (404 errors) - Fixed Content Security Policy font loading errors - Resolved PatternFly topology light background issues Result: VSCode extension now automatically adapts topology visualization to match user's preferred theme without any manual intervention. Closes #1 Signed-off-by: Brian Cook <[email protected]>
- Align local and GitHub Actions to both use 'yarn run release:check' - Fix script execution order: CI → propagate → build:vscode - Enhance propagation script with cross-platform file operations - Add comprehensive debugging output for CI troubleshooting - Replace shell commands (cp/rm) with Node.js fs operations - Add path verification and error handling - Restore accidentally moved tekton-vscode files The key fix: propagation must happen BEFORE building VSCode extension, so the bundled ../lib/tekton-renderer files exist when webpack runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Key Features:
🔧 Technical Implementation:
🧪 Testing & Quality:
🐛 Bug Fixes:
Result: VSCode extension now automatically adapts topology visualization to match user's preferred theme without any manual intervention.
Closes #1