Resolved aws_subnet_ids deprecation

[azend]

Note: changes are untested and should be reviewed before merge.

This PR updates the data resource that provides AWS subnet IDs. This change removes the deprecation warning caused by the old resource type.

Issue is described in #22 .

[kvwake]

--- a/README.md
+++ b/README.md
@@ -102,7 +102,7 @@ No modules.
 | [aws_partition.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/partition) | data source |
 | [aws_region.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/region) | data source |
 | [aws_route_table.selected](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/route_table) | data source |
-| [aws_subnet_ids.selected](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/subnet_ids) | data source |
+| [aws_subnets.selected](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/subnets) | data source |
 | [aws_vpc.selected](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/vpc) | data source |

[azend]

Just a reminder that I can’t merge these changes because I’m not a project member.

[chrismazanec]

@kvwake @azend have you tested the code? I have introduced this fix here; https://github.com/bridgecrewio/terraform-aws-session-manager/pull/20/files#diff-d27b6bbb73d8ee24ac0b6cae34cdddcde2c220a0ed46e41cfd5b36e4a61b41abR3 long time ago, I believe that should read data.aws_subnets.selected[0].ids to support count in aws_subnets resource. your code won't work since

Because data.aws_subnets.selected has "count" set, its attributes must be
│ accessed on specific instances.
│
│ For example, to correlate with indices of a referring resource, use:
│     data.aws_subnets.selected[count.index]
╵

[azend]

I didn't until now. It seemed like no one was maintaining this repo so I got it working for what I needed it for then lost interest. You're definitely right about the resource index being in the wrong spot. I've fixed it in my fork, validated syntax with terraform validate and planned it against my deployed environment. It results in 0 changes save the no longer present deprecation warning. Cheers.

[cfenogli0]

Can someone merge this change? I am attempting to use the module with a later version of AWS and am completely blocked

[azend]

I can't. We need a repo maintainer to merge.