expanded module functionality #6
Conversation
- all changes backwards compatible - cleanup (trailing spaces, formatting, removed unused entities) - all resources created dynamically using `count` or `for_each` depending on module configuration - added outputs descriptions - added new variables/module options to better cover SSM preferences : `bucket_key_prefix`, `idle_session_timeout`, `run_as_default_user`, `shell_profile_windows`, `shell_profile_linux`, `enable_run_as` - added new outputs: `iam_policy_arn`, `document_name`, `document_arn` - updated `README.md` accordingly, added `Requirements`, `Providers` and `Notes` sections - addressed bridgecrewio#2 by removing unused code blocks
|
can you update to the current master and ill review it again, |
|
Hiya! Any update on this? I just need to be able to use the shell profiles logic. I made a PR here #17 |
|
i think most of this PR has made it one way or another to the module, if you sync with master we can see if theres anything else? |
|
|
||
| ## SSM Usage Example | ||
|
|
||
| * Launch an instance using the ssm_profile created by Terraform | ||
| * Launch an instance using the ssm\_profile created by Terraform |
There was a problem hiding this comment.
Could you clarify what you mean by 'launch an instance using a profile'?
Does this only work for newly launched instances?
What is meant by an Instance Profile?
There was a problem hiding this comment.
It's been a while but my memory says that it refers to the instance profile that allows ssm actions for a given instance. You can apply that profile to existing insurances.
|
hi all, I addressed part of this PR in a new one; |
countorfor_eachdepending on module configurationbucket_key_prefix,idle_session_timeout,run_as_default_user,shell_profile_windows,shell_profile_linux,enable_run_asiam_policy_arn,document_name,document_arnREADME.mdaccordingly, addedRequirements,ProvidersandNotessections