Fix DeepSeek-V4 Native history across prefill chunks - #30
Open
remer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Summary
Root cause
The request-scoped Native history allocation is shared across layers and across the main and learned-index compressors. It therefore cannot preserve one compressor's prefix across intervening owners or later prefill chunks. The previous
active_prefill_chunk_idx == 0guard skipped the required restore after chunk 0, allowing learned-index selection to consume mixed history.The packed Native cache remains the persistent source of truth. This change restores its prefix whenever
first_group > 0before appending new rows.Validation
git diff --checkThe source-build compatibility change used on the validation host is intentionally excluded from this PR.