-
Notifications
You must be signed in to change notification settings - Fork 300
refactor: remove multisession tools, remove prompts sampling, simplif… #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y tool descriptions for better context, add support if google apikey set, latest version of stagehand, remove custom availmodelschema to use stagehand
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
src/index.ts
Outdated
import { AvailableModelSchema } from "./types/models.js"; | ||
import { PROMPTS, getPrompt } from "./mcp/prompts.js"; | ||
import { AvailableModelSchema } from "@browserbasehq/stagehand"; | ||
// import { PROMPTS, getPrompt } from "./mcp/prompts.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you keeping these for the future?
src/index.ts
Outdated
ListPromptsRequestSchema, | ||
GetPromptRequestSchema, | ||
// ListPromptsRequestSchema, | ||
// GetPromptRequestSchema, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
src/index.ts
Outdated
// server.server.setRequestHandler(GetPromptRequestSchema, async (request) => { | ||
// const prompt = getPrompt(request.params.name); | ||
// return prompt; | ||
// }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
src/mcp/prompts.ts
Outdated
// if (!PROMPTS.some((prompt) => prompt.name === name)) { | ||
// throw new Error(`Invalid prompt name: ${name}`); | ||
// } | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
638aed8
to
ff3cda0
Compare
…ocs (#1140) # why We recently shipped updates to our MCP server that should be reflected in the documentation. # what changed update tools list for MCP update, removing mentions of multisession, adding experimental flag + get url tool related PR: browserbase/mcp-server-browserbase#123 # test plan n/a
…ocs (#1140) # why We recently shipped updates to our MCP server that should be reflected in the documentation. # what changed update tools list for MCP update, removing mentions of multisession, adding experimental flag + get url tool related PR: browserbase/mcp-server-browserbase#123 # test plan n/a
what
Remove multisession tools, remove prompts sampling, simplify tool descriptions for better context, add support if google apikey set, latest version of stagehand, remove custom availmodelschema to use stagehand model type instead.
added some jsdoc tool descriptions and links
also refactored session management logic, isolating sessionmanager to individual contexts.
testing
ran regression evals