Addressed comments

Author: mattscepter

lib/core/public/run-rules.js

@@ -37,10 +37,12 @@ export default function runRules(context, options, resolve, reject) {
     performanceTimer.auditStart();
   }
 
-  if (options.a11yEngineConfig && options.a11yEngineConfig.advancedRun) {
+  // If advanced run for iframes is true then setup socket for iframes
+  if (options.a11yEngineConfig && options.a11yEngineConfig.iframesAdvancedRun) {
     a11yEngine.setup(options.a11yEngineConfig);
   }
 
+  // If run for iframes is true then collect results from iframes
   if (context.frames.length && options.iframes === true) {
     q.defer((res, rej) => {
       collectResultsFromFrames(context, options, 'rules', null, res, rej);

lib/core/utils/collect-results-from-frames.js

@@ -22,9 +22,12 @@ export default function collectResultsFromFrames(
   // elementRefs can't be passed across frame boundaries
   options = { ...options, elementRef: false };
 
-  // check a11yengine advance run flag
-  if (options.a11yEngineConfig && !options.a11yEngineConfig.advancedRun) {
-    options.a11yEngineConfig.advancedRun = true;
+  // check a11yengine iframe advance run flag
+  if (
+    options.a11yEngineConfig &&
+    options.a11yEngineConfig.iframesAdvancedRun === false
+  ) {
+    options.a11yEngineConfig.iframesAdvancedRun = true;
   }
 
   var q = queue();

lib/core/utils/merge-results.js

@@ -76,6 +76,7 @@ function normalizeResult(result) {
  */
 function mergeResults(frameResults, options) {
   const mergedResult = [];
+  // A11yEngine merged errors
   let mergedErrors = {};
   frameResults.forEach(frameResult => {
     const results = normalizeResult(frameResult);
@@ -84,6 +85,7 @@ function mergeResults(frameResults, options) {
     }
 
     const frameSpec = getFrameSpec(frameResult);
+    // Extract existing errors and merge with new ones
     if (results[results.length - 1].a11yEngineErrors) {
       const error = results.pop();
       delete error.a11yEngineErrors;