UMP v3 token support with Argon2id password KDF - #5
Merged
Conversation
BraydenLangley
self-requested a review
March 26, 2026 19:19
Collaborator
|
Ran integration testing with new wallet-toolbox changes locally. |
BraydenLangley
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add UMP v3 token support to the overlay backend — topic manager and lookup service
now parse and validate KDF metadata fields (umpVersion, kdfAlgorithm, kdfParams)
from on-chain tokens.
Fixes a v3 detection bug where tokens without an encrypted-profiles field had
umpVersion at field index 11 (not 12), causing them to be treated as legacy tokens.
Detection now checks both layouts: single-byte at field[11] = v3 without profiles,
single-byte at field[12] = v3 with profiles.
Also adds a Jest test suite with 29 unit tests covering both the topic manager and
lookup service, including legacy tokens, v3 tokens with and without profiles, and
invalid/edge-case inputs. Includes the Jest/ts-jest configuration needed to run
tests in this LARS project structure.
Linked Issues / Tickets
n/a
Testing Procedure
New unit tests in
backend/src/__tests/:UMPTopicManager.test.ts— validates admission logic for legacy tokens, v3 tokens(with/without profiles), insufficient fields, invalid KDF metadata, and
unsupported KDF algorithms
UMPLookupServiceFactory.test.ts— validates indexing and lookup of presentationhash, recovery hash, and outpoint for both legacy and v3 tokens
I have added new unit tests
All tests pass locally
I have tested manually in my local environment
Checklist:
npm run docandnpm run lintone final time before requesting a reviewnpm version patchso that my changes will trigger a new version to be released when they are merged