Skip to content

Support forwarding unknown HTTP requests from the cache proxy #10293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Support forwarding unknown HTTP requests from the cache proxy #10293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions enterprise/server/cmd/cache_proxy/cache_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import (
"flag"
"fmt"
"net/http"
"net/http/httputil"
"net/url"
"os"

"github.com/buildbuddy-io/buildbuddy/enterprise/server/action_cache_server_proxy"
Expand Down Expand Up @@ -49,10 +51,11 @@ import (
)

var (
listen = flag.String("listen", "0.0.0.0", "The interface to listen on (default: 0.0.0.0)")
port = flag.Int("port", 8080, "The port to listen for HTTP traffic on")
sslPort = flag.Int("ssl_port", 8081, "The port to listen for HTTPS traffic on")
monitoringPort = flag.Int("monitoring_port", 9090, "The port to listen for monitoring traffic on")
listen = flag.String("listen", "0.0.0.0", "The interface to listen on (default: 0.0.0.0)")
port = flag.Int("port", 8080, "The port to listen for HTTP traffic on")
sslPort = flag.Int("ssl_port", 8081, "The port to listen for HTTPS traffic on")
monitoringPort = flag.Int("monitoring_port", 9090, "The port to listen for monitoring traffic on")
httpProxyTarget = flag.String("http_proxy_target", "", "The HTTP target to forward unknown HTTP requests to.")

serverType = flag.String("server_type", "cache-proxy", "The server type to match on health checks")

Expand Down Expand Up @@ -129,6 +132,19 @@ func main() {
env.GetMux().Handle("/healthz", env.GetHealthChecker().LivenessHandler())
env.GetMux().Handle("/readyz", env.GetHealthChecker().ReadinessHandler())

if *httpProxyTarget != "" {
httpProxyUrl, err := url.Parse(*httpProxyTarget)
if err != nil {
log.Fatalf("Could not parse http proxy url: %v", err)
}
proxy := httputil.NewSingleHostReverseProxy(httpProxyUrl)

// Fallback to forward any unmatched HTTP routes to the proxy target.
env.GetMux().Handle("/", http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
proxy.ServeHTTP(w, req)
}))
}

server := &http.Server{
Addr: fmt.Sprintf("%s:%d", *listen, *port),
Handler: env.GetMux(),
Expand Down
Loading