Skip to content

Conversation

bduffany
Copy link
Member

No description provided.

@bduffany bduffany force-pushed the invocation-backfill branch 3 times, most recently from a650001 to a9aa5c3 Compare September 18, 2025 17:55
@bduffany bduffany force-pushed the invocation-backfill branch 4 times, most recently from b5f7568 to 1eb4c46 Compare September 18, 2025 19:19
Copy link
Contributor

@vanja-p vanja-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small nits but this LGTM

seenInvocations[iidStr] = invocation
select {
case <-ctx.Done():
return ctx.Err()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could do the batching here. It would probably be less code, and at least the findmissing batches would each be for one group.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bduffany bduffany force-pushed the invocation-backfill branch 2 times, most recently from 92885fd to 32167af Compare September 18, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants