-
Notifications
You must be signed in to change notification settings - Fork 116
Add invocation backfill tool #10302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add invocation backfill tool #10302
Conversation
a650001
to
a9aa5c3
Compare
b5f7568
to
1eb4c46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple small nits but this LGTM
seenInvocations[iidStr] = invocation | ||
select { | ||
case <-ctx.Done(): | ||
return ctx.Err() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could do the batching here. It would probably be less code, and at least the findmissing batches would each be for one group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
92885fd
to
32167af
Compare
32167af
to
db727c3
Compare
No description provided.