Update docusaurus for dependabot #10404
Open
+2,974
−4,570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tempoz
force-pushed
the
dependabot-223
branch
from
b7db96c to
c0a7f7d
Compare
|
@tempoz, what do you think about doing the Node upgrade separately? And going to the most recent stable version? |
sluongng
reviewed
Oct 2, 2025
There was a problem hiding this comment.
I scanned through the change log in https://github.com/facebook/docusaurus/releases and did not notice anything breaking between 3.6.3 and 3.9.1.
👍 to Dan's suggestion: let's move the nodejs upgrade to a separate PR. Though I don't think we would be able to upgrade it to the very latest because we might need a rules_nodejs upgrade before that.
|
node 20 is the most recent LTS, which is why I picked it. Happy to separate it out, though. |
|
I've separated out the node upgrade now. |
dan-stowell
approved these changes
Oct 2, 2025
sluongng
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/buildbuddy-io/buildbuddy/security/dependabot/223
Also upgraded node since the newest docusaurus requires node 20.