Upgrade node to 22 #10425
Open
Upgrade node to 22 #10425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sluongng points out we may need to upgrade |
|
What's the correct order to bump this dependency? Merge the change here, then in the internal repo? |
|
They need to be done at basically the same time :/ |
|
I have had a goal for a while of having internal use buildbuddy to determine these toolchain versions, but it didn't pan when I first tried. Might be worth looking at again. |
tempoz
force-pushed
the
upgrade-to-node-22
branch
from
b7d2f90 to
ede55d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Dan correctly points out, this is ACTUALLY the latest LTS version of
node.This lets us upgrade docusaurus, which allows us to stop depending on a vulnerable version of tar-fs:
https://github.com/buildbuddy-io/buildbuddy/security/dependabot/223