[terminal ui] re-render terminal upon entering full-screen #10428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
approved these changes
Oct 3, 2025
bduffany
reviewed
Oct 3, 2025
app/terminal/terminal.tsx
Outdated
Comment on lines
105
to
107
| window.addEventListener("keydown", (this.windowKeyDownListener = this.onWindowKeyDown.bind(this))); | ||
| window.addEventListener("fullscreenchange", (this.fullScreenListener = () => this.forceUpdate.bind(this))); | ||
| window.addEventListener("fullscreenchange", (this.fullScreenListener = () => this.forceUpdate())); | ||
| window.addEventListener("resize", (this.resizeListener = this.updateLineLengthLimit.bind(this))); |
There was a problem hiding this comment.
nit: maybe use arrow functions instead of bind in the other listeners too? just for consistency
There was a problem hiding this comment.
This change does use arrows? Previous code used bind? Or am I misunderstanding?
There was a problem hiding this comment.
"Other listeners." Sorry, yeah, I'll do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you press the full-screen button on a terminal in the UI, it will enter full-screen but not re-render the text to take advantage of all the space. Clicking inside the terminal causes a re-render.
With this change, the text re-renders the moment the terminal enters full screen.
