Add RV and AbV designation #944
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IfcTextLiteral is part of the RV and AbV, but is abstract. This class should be part of the RV and AbV.
Collaborator
|
So the issue is that the templates are referencing it, while the documentation talks about it being abstract-deprecated (there isn't a word for it really I think, but "direct usage is deprecated use subtypes instead"). By having the templates nominate the subtype we do justice to this. Although I must admit I don't understand the rationale behind the deprecation. See #947 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IfcTextLiteral is part of the RV and AbV, but is abstract. This class should be part of the RV and AbV.