Skip to content

Conversation

@civilx64
Copy link
Contributor

(IVS-337)

Copy link
Collaborator

@aothms aothms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the only thing to think about is Zones and Systems maybe, which are subtypes of groups and use the same relationship. For end-users I can imagine it is confusing that Zones and Systems count as groups.

Copy link
Collaborator

@aothms aothms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing we have a SYS000 planned as well, I do think we should exclude subtypes and only specifically have IfcGroup trigger activation in this rule.

@civilx64
Copy link
Contributor Author

We have GRP001 already active and explicitly includes systems (and zones as a subtype of systems) in the feature description. SYS000 is indeed in the backlog but SYS001 is disabled. My preference would be to leave this rule as-is, especially since the feature description references a concept template that includes systems. We could still move forward with SYS000 and scope it to IfcSystem and subtypes. A model correctly utilizing those entities would then activate the GRP and SYS functional parts, which IMHO makes sense. It seems logical that a zone is a group of spaces and a system is a group of things like electrical circuits or other distribution systems like stormwater drainage pipes, inlet, and manholes.

@civilx64
Copy link
Contributor Author

Per JIRA discussion: Merge GRP000 as-is. SYS000 deleted from catalog as SYS is not in the final list of functional parts.

@civilx64 civilx64 merged commit ac8a143 into development Nov 20, 2025
2 checks passed
@civilx64 civilx64 deleted the IVS-337-GRP000-groups branch November 20, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants