Skip to content

Conversation

@Yasir761
Copy link

Description

Fix ProjectDeploymentListItem dropdown menu

Fixes #3266

Copy link
Collaborator

@kresimir-coko kresimir-coko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run npm run format and npm run typecheck.

Some notes before looking at the details of the implementation:

  • Remove comments.
  • If statements require braces around the return;
  • Don't use shorthand terms like e for event
  • Single invocations don't require braces (lines 197-206)
  • Record a video of how it looks like after your changes

@Yasir761
Copy link
Author

Here’s a quick demo of the changes: Loom Video

Copy link
Collaborator

@kresimir-coko kresimir-coko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, a couple things missing.

  • Cursor should be cursor-pointer indicating that the card is clickable
  • Clicks on the dropdown (as indicated in video) shouldn't open the card
  • On line 92 we have a single line if statement, make sure the return is wrapped with braces
  • On line 125 there is a leftover comment
Screen.Recording.2025-10-22.at.09.40.48.mov

@kresimir-coko
Copy link
Collaborator

@Yasir761 did you fix these 2 points?

  • Cursor should be cursor-pointer indicating that the card is clickable
  • Clicks on the dropdown (as indicated in video) shouldn't open the card

@Yasir761
Copy link
Author

@Yasir761 did you fix these 2 points?

  • Cursor should be cursor-pointer indicating that the card is clickable
  • Clicks on the dropdown (as indicated in video) shouldn't open the card

Now they work as expected

@kresimir-coko
Copy link
Collaborator

@Yasir761 Clicks on the dropdown (as indicated in video) shouldn't open the card. Make sure to check it manually if it works as expected, I pulled your code and clicked on the dropdown's options and it toggles the card

@Yasir761
Copy link
Author

@kresimir-coko, Hey, I just attached the Loom video showing that dropdown. Here is the link video

@kresimir-coko
Copy link
Collaborator

@Yasir761 the one on the right, that opens when you click on the Button represented by the 3 vertical dots. Sorry for the confusion.

image

@Yasir761
Copy link
Author

Yasir761 commented Nov 3, 2025

@kresimir-coko, can you review the changes? I guess I solved them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the entire Deployment card clickable to open the list of workflows

3 participants