Skip to content

When dragging a component from the right side panel, the dragged element should be just the icon #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

When dragging a component from the right side panel, the dragged element should be just the icon #3408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 48 additions & 27 deletions ...c/pages/platform/workflow-editor/components/workflow-nodes-tabs/WorkflowNodesTabsItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,17 @@ import {
ComponentDefinitionBasic,
TaskDispatcherDefinition,
} from '@/shared/middleware/platform/configuration';
import {ComponentIcon} from 'lucide-react';
import {HTMLAttributes, MouseEvent, useEffect, useRef, useState} from 'react';
import { ComponentIcon } from 'lucide-react';
import { HTMLAttributes, MouseEvent, useEffect, useRef, useState } from 'react';
import InlineSVG from 'react-inlinesvg';
import {twMerge} from 'tailwind-merge';
import { twMerge } from 'tailwind-merge';


interface DragEventI<T = Element> extends MouseEvent<T, DragEventInit> {
dataTransfer: DataTransfer;
}


interface WorkflowNodesTabsItemProps extends HTMLAttributes<HTMLLIElement> {
handleClick?: () => void;
node: (ComponentDefinitionBasic | TaskDispatcherDefinition | ClusterElementDefinitionBasic) & {
Expand All @@ -20,27 +22,56 @@ interface WorkflowNodesTabsItemProps extends HTMLAttributes<HTMLLIElement> {
trigger: boolean;
};
selected?: boolean;
draggable?: boolean;
}

const WorkflowNodesTabsItem = ({draggable, handleClick, node, selected}: WorkflowNodesTabsItemProps) => {
const WorkflowNodesTabsItem = ({
draggable,
handleClick,
node,
selected,
}: WorkflowNodesTabsItemProps) => {
const [isVisible, setIsVisible] = useState(false);
const ref = useRef<HTMLLIElement>(null);


let nodeName = node.name;
if (node.trigger) nodeName = `${node.name}--trigger`;
if (node.taskDispatcher) nodeName = `${node.name}--taskDispatcher`;

if (node.trigger) {
nodeName = `${node.name}--trigger`;
}

if (node.taskDispatcher) {
nodeName = `${node.name}--taskDispatcher'`;
}


const onDragStart = (event: DragEventI) => {
event.dataTransfer.setData('application/reactflow', nodeName);
event.dataTransfer.effectAllowed = 'move';

const dragIcon = document.createElement('img');

if (node.icon) {
dragIcon.src = node.icon;
} else {

dragIcon.src =
'data:image/svg+xml;base64,PHN2ZyBmaWxsPSJub25lIiBoZWlnaHQ9IjI0IiBzdHJva2U9IiM4ODgiIHN0cm9rZS13aWR0aD0iMS41IiB2aWV3Qm94PSIwIDAgMjQgMjQiIHdpZHRoPSIyNCIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj48cGF0aCBkPSJNMTIgNWMxLjM3IDAgMi41Ljg5IDIuODYgMi4xOGwxLjA0LTIuMDhjLS40Mi0uMTItLjg3LS4xOC0xLjMuMThBNC41IDQuNSAwIDAgMCAxMiA0Yy0yLjQ4IDAtNCAxLjUyLTQgMy41IDAgMi4zOCAxLjk1IDQuNS00LjUgNC41UzguNSA5Ljg4IDggOC41YTMuNSA0LjUgMCAwIDEgMy4wMi0zLjM1bC0uNzMtMS45OEExMiAxMiAwIDEgMSAxMiA1WiIvPjwvc3ZnPg==';
}


dragIcon.style.width = '32px';
dragIcon.style.height = '32px';
dragIcon.style.position = 'absolute';
dragIcon.style.top = '-1000px';
dragIcon.style.left = '-1000px';
document.body.appendChild(dragIcon);


event.dataTransfer.setDragImage(dragIcon, 16, 16);


setTimeout(() => {
document.body.removeChild(dragIcon);
}, 0);
};


useEffect(() => {
const observer = new IntersectionObserver(
([entry]) => {
Expand All @@ -49,16 +80,10 @@ const WorkflowNodesTabsItem = ({draggable, handleClick, node, selected}: Workflo
observer.disconnect();
}
},
{
rootMargin: '50px',
threshold: 0.1,
}
{ rootMargin: '50px', threshold: 0.1 }
);

if (ref.current) {
observer.observe(ref.current);
}

if (ref.current) observer.observe(ref.current);
return () => observer.disconnect();
}, []);

Expand All @@ -70,20 +95,17 @@ const WorkflowNodesTabsItem = ({draggable, handleClick, node, selected}: Workflo
)}
draggable={draggable}
id={node?.title}
ref={ref}
onClick={(event) => {
if (handleClick) {
handleClick();
}

event.stopPropagation();
handleClick?.();
}}
onDragStart={(event) => onDragStart(event)}
ref={ref}
>
{node.icon ? (
isVisible ? (
<InlineSVG
cacheRequests={true}
cacheRequests
className="mr-2 size-7 flex-none"
loader={<ComponentIcon className="mr-2 size-7 flex-none" />}
src={node.icon}
Expand All @@ -98,7 +120,6 @@ const WorkflowNodesTabsItem = ({draggable, handleClick, node, selected}: Workflo

<div className="flex flex-col">
<p className="text-sm font-medium">{node?.title}</p>

<p className="line-clamp-2 text-left text-xs text-muted-foreground">{node?.description}</p>
</div>
</li>
Expand Down