Skip to content

Conversation

@katarina-cala
Copy link
Collaborator

Updated workflow executions accordion and content by following the figma design (with few necessary adjustments) in:

  • workflow executions sheet (both automation & embedded mode)
  • workflow test output (both workflow editor bottom panel & code editor side panel)

@katarina-cala katarina-cala changed the title Workflow executions updates 3002 - Workflow executions updates Nov 19, 2025
@ivicac ivicac force-pushed the workflow_executions_updates branch from 8843faa to ee0123f Compare November 19, 2025 17:40
@ivicac ivicac force-pushed the workflow_executions_updates branch from ee0123f to 81f2093 Compare November 19, 2025 20:34
@ivicac ivicac requested a review from Copilot November 19, 2025 20:36
Copilot finished reviewing on behalf of ivicac November 19, 2025 20:38
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'client'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
20.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the workflow executions UI to match the new Figma design, implementing collapsible task dispatchers with an accordion-based interface. The changes affect both automation and embedded workflow execution views, as well as the workflow test output panels.

Key Changes:

  • Refactored workflow execution UI to use accordion components with nested task trees supporting loop iterations
  • Extracted reusable components and utility functions for better code organization
  • Updated animations and styling to match the new design system
  • Implemented tabbed interface for input/output/error display with expandable dialogs

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
client/tailwind.config.js Updated accordion animation timing from 0.2s to 300ms with forwards fill mode
client/src/shared/components/workflow-executions/WorkflowTriggerExecutionItem.tsx Simplified trigger item UI, removed selection state, added status icons
client/src/shared/components/workflow-executions/WorkflowTaskExecutionItem.tsx Simplified task item UI, removed selection state, added status icons
client/src/shared/components/workflow-executions/WorkflowExecutionsUtils.ts New utility file with task tree building, output filtering, and helper functions
client/src/shared/components/workflow-executions/WorkflowExecutionsTriggerAccordionItem.tsx New accordion item component for trigger executions with selection styling
client/src/shared/components/workflow-executions/WorkflowExecutionsTaskAccordionItem.tsx New recursive accordion component supporting nested tasks and loop iterations
client/src/shared/components/workflow-executions/WorkflowExecutionsTabsPanel.tsx New tabbed panel component for displaying input/output/error with dialog expansion
client/src/shared/components/workflow-executions/WorkflowExecutionsHeader.tsx New header component displaying execution status and metadata
client/src/shared/components/workflow-executions/WorkflowExecutionContentClipboardButton.tsx Enhanced clipboard button with toast notifications and success state
client/src/shared/components/workflow-executions/WorkflowExecutionContent.tsx Refactored content component with conditional rendering for input/output/error
client/src/pages/platform/workflow-editor/components/WorkflowExecutionsTestOutput.tsx Updated to use new accordion-based layout with resizable panels
client/src/pages/automation/workflow-executions/components/workflow-execution-sheet/WorkflowExecutionSheetContent.tsx New content component for automation workflow execution sheet
client/src/pages/automation/workflow-executions/components/workflow-execution-sheet/WorkflowExecutionSheetAccordion.tsx Removed legacy accordion component
client/src/pages/automation/workflow-executions/components/workflow-execution-sheet/WorkflowExecutionSheet.tsx Updated to use new resizable layout with loading states
client/src/ee/pages/embedded/workflow-executions/components/workflow-execution-sheet/WorkflowExecutionSheetContent.tsx New content component for embedded workflow execution sheet
client/src/ee/pages/embedded/workflow-executions/components/workflow-execution-sheet/WorkflowExecutionSheetAccordion.tsx Removed legacy accordion component
client/src/ee/pages/embedded/workflow-executions/components/workflow-execution-sheet/WorkflowExecutionSheet.tsx Updated to use new resizable layout with loading states
client/.eslintrc Added new CSS class names to ESLint whitelist

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +15 to +16
'accordion-down': 'accordion-down 300ms ease-out forwards',
'accordion-up': 'accordion-up 300ms ease-out forwards',
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The animation timing has been changed from 0.2s to 300ms, which are equivalent values. However, using forwards fill mode could cause issues if the accordion animation needs to be repeatable or if there are multiple accordions animating at the same time.

The forwards fill mode makes the animation retain its final state after completion, which might not be necessary for accordion animations that typically complete their state transition naturally. Consider whether forwards is needed or if the default behavior would suffice:

'accordion-down': 'accordion-down 300ms ease-out',
'accordion-up': 'accordion-up 300ms ease-out',
Suggested change
'accordion-down': 'accordion-down 300ms ease-out forwards',
'accordion-up': 'accordion-up 300ms ease-out forwards',
'accordion-down': 'accordion-down 300ms ease-out',
'accordion-up': 'accordion-up 300ms ease-out',

Copilot uses AI. Check for mistakes.
@ivicac
Copy link
Contributor

ivicac commented Nov 19, 2025

@katarina-cala, can you please check Copilot messages?

@ivicac ivicac merged commit e1f2a26 into master Nov 20, 2025
12 of 13 checks passed
@ivicac ivicac deleted the workflow_executions_updates branch November 20, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants