Remove duplicate printing from Alcotest backend#405
Merged
jmid merged 2 commits intoc-cube:mainfrom Feb 17, 2026
Merged
Conversation
removes duplicate pretty printing and stack traces from erroneous output when using the Alcotest backend for QCheck.
jmid
reviewed
Feb 16, 2026
Collaborator
jmid
left a comment
jmid
left a comment
There was a problem hiding this comment.
Thanks, this makes sense to me 👍
Triggering a CI run I see this failing expect tests, because "double printing" is missing - effectively giving the example test I was going to ask about.
Can you update and commit the updated expect tests so that dune runtest example/alcotest passes locally?
Also, a CHANGELOG entry would be welcome!
add CHANGELOG entry for removing duplicate printing update expected output for Alcotest examples to reflect removal of duplicated printing
Contributor
Author
|
Removed the duplicated output from expected. Additionally, locally, it's also complaining about the size of the boxes (though it didn't do that in the previous CI run), so I'm going to see if that changed as well. |
jmid
approved these changes
Feb 17, 2026
Collaborator
jmid
left a comment
jmid
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that when using the
Alcotestbackend forQCheck, there is duplicated output pretty printer output on test failures - one set fromAlcotestand one set fromQCheck.I believe a similar issue is mentioned in #103. I think I have corrected this issue in this PR, however, I would love a maintainer to sanity check me, as I'm not incredibly familiar with the
QCheckcodebase.Thanks!