FIX: [ProfitFixer] warning on no trades and update fixed position timestamps #2247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9s
reviewed
Oct 3, 2025
pkg/strategy/common/profit_fixer.go
Outdated
| return err | ||
| } | ||
| if len(allTrades) == 0 { | ||
| log.Warnf("no trades found for %s from %s to %s, skip profit fixing", symbol, since.String(), until.String()) |
There was a problem hiding this comment.
use "no trades found between t1 and t2"?
pkg/strategy/common/profit_fixer.go
Outdated
| return err | ||
| } | ||
| // update position open time and changed time | ||
| position.OpenedAt = since |
There was a problem hiding this comment.
should use the time from the first trade
c9s
reviewed
Oct 3, 2025
pkg/strategy/common/profit_fixer.go
Outdated
| } | ||
| // update position open time and changed time | ||
| position.OpenedAt = since | ||
| position.ChangedAt = allTrades[len(allTrades)-1].Time.Time() |
There was a problem hiding this comment.
this field will be updated when a trade is added to the position?
There was a problem hiding this comment.
You're right.
Will remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.