downgrade thrift to backend compatible version #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Groxx,
shijiesheng,
agautam478,
jakobht,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
|
Hmm 🤔 |
|
hmm in the monorepo the version is set to 0.17.0 and it client works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I downgraded apache/thrfit version to the version compatible on the Cadence backend.
Why?
Cadence backend uses client to run internal operations, so client should be compatible with the backend.
How did you test it?
unit tests/integration tests
Potential risks
Potential failures for customers using up to date thrift version.