change dependency management in favor of pyproject.toml and uv #6
+30
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
reviewed
Aug 5, 2025
There was a problem hiding this comment.
readme says python scripts/generate_protobuf_final.py but we only have scripts/generate_protobuf.py Running the script shows a bunch of files deleted. Is the new script checked-in?
There was a problem hiding this comment.
I got error
✗ Failed to generate files for cadence/api/v1/common.proto: Command '['/Users/shengs/code/me/cadence-python-client/.bin/protoc-29.1', '--python_out=/Users/shengs/code/me/cadence-python-client/cadence', '--pyi_out=/Users/shengs/code/me/cadence-python-client/cadence', '--proto_path=/Users/shengs/code/me/cadence-python-client/.temp_proto', '--proto_path=/opt/homebrew/include', '/Users/shengs/code/me/cadence-python-client/.temp_proto/cadence/api/v1/common.proto']' returned non-zero exit status 1.
stderr: google/protobuf/duration.proto: File not found.
There was a problem hiding this comment.
Thanks for pointing that out, it should be generate_proto.py
@davidporter-id-au Hi, which lock file are you referring to? |
shijiesheng
approved these changes
Aug 5, 2025
|
uv generates a lock of dependencies https://docs.astral.sh/uv/guides/projects/#uvlock this should be comitted: (cf: astral-sh/uv#9797) |
|
cc @timl3136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
requirements.txtin favor ofpyproject.tomlas the single source of truth for dependenciesuvas the recommended package installer with Homebrew support for macOS>=3.11,<3.12to>=3.11,<3.14(adds Python 3.12 and 3.13 support)pyproject.tomluv-based setup instructions while maintaining backward compatibility with traditional pipWhy?
remove duplicate dependency management
How did you test it?
Test run command in
readmePotential risks
Release notes
Documentation Changes