Skip to content

Conversation

@Assem-Uber
Copy link
Contributor

@Assem-Uber Assem-Uber commented Oct 15, 2025

Summary
We want to allow users to add search attributes while starting workflow. Component will allow users to get existing custom search attributes and give them value based on the attribute index type (number,date, string etc).

Screenshots
Screenshot 2025-10-15 at 10 12 40
Screenshot 2025-10-15 at 10 13 01
Screenshot 2025-10-15 at 10 12 54

Signed-off-by: Assem Hafez <[email protected]>
Signed-off-by: Assem Hafez <[email protected]>
@Assem-Uber Assem-Uber changed the title Search attribute component feat: Search attribute component Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new search attributes component that allows users to manage custom search attributes when starting workflows. The component provides dynamic input types based on attribute value types (string, number, boolean, datetime) and includes validation for complete entries.

Key Changes:

  • Implemented a new WorkflowActionsSearchAttributes component with dynamic input type rendering based on attribute value types
  • Added comprehensive test coverage with 20+ test cases covering various user interactions and edge cases
  • Created reusable type definitions and constants for search attribute management

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
workflow-actions-search-attributes.types.ts Defines TypeScript types for search attributes, including option types, item structure, and component props
workflow-actions-search-attributes.tsx Main component implementation with dynamic input rendering, validation logic, and attribute management
workflow-actions-search-attributes.styles.ts Styling configuration using Styletron with flex-based layout for attribute rows
workflow-actions-search-attributes.constants.ts Constants for boolean options and input placeholders mapped to attribute value types
workflow-actions-search-attributes.test.tsx Comprehensive test suite covering component rendering, user interactions, and validation scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Assem-Uber
Copy link
Contributor Author

Screenshot after updating label and icon
Screenshot 2025-10-23 at 17 01 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants