refactor: Update Cadence IDLs to use latest active-active design changes #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adhitya Mamallan <[email protected]>
adhityamamallan
force-pushed
the
active-active-idl
branch
from
6d8c23b to
4e7d5a6
Compare
adhityamamallan
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Cadence Web UI to use the latest active-active domain design from the Cadence IDL. The key change is moving from regionToCluster to activeClustersByClusterAttribute for identifying active-active domains, with activeClusterName now being set for all domain types including active-active domains.
- Updated IDL version to latest commit
- Refactored
isActiveActiveDomainto checkactiveClustersByClusterAttributeinstead ofregionToCluster - Removed logic for finding default active cluster since
activeClusterNameis now set for active-active domains
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated cadence_idl_version to latest commit |
| src/views/shared/active-active/helpers/is-active-active-domain.ts | Changed to check activeClustersByClusterAttribute instead of regionToCluster |
| src/views/shared/active-active/fixtures/active-active-domain.ts | Updated fixture to use new active-active structure with activeClustersByClusterAttribute |
| src/views/redirect-domain/redirect-domain.tsx | Removed default cluster logic, now directly uses activeClusterName |
| src/views/domains-page/helpers/get-unique-domains.ts | Simplified to use activeClusterName directly instead of computing default cluster |
| src/views/domains-page/domains-table-domain-name-cell/domains-table-domain-name-cell.tsx | Removed default cluster logic and uses activeClusterName directly |
| src/views/domain-page/domain-page-metadata-clusters/domain-page-metadata-clusters.tsx | Simplified active cluster check to compare with activeClusterName directly |
| src/views/domain-page/domain-page-metadata-failover-version/domain-page-metadata-failover-version.tsx | Temporarily returns simple failover version instead of SublistTable for active-active domains |
| src/views/domain-page/helpers/get-default-cluster-for-active-active-domain.ts | Removed entire file as default cluster logic is no longer needed |
| src/views/domain-page/helpers/is-active-cluster.ts | Removed entire file as check is now simplified |
| src/views/workflow-summary/workflow-summary-details/workflow-summary-details.constants.ts | Removed active cluster selection strategy constants |
| src/views/workflow-summary/workflow-summary-details/helpers/get-active-cluster-selection-policy.ts | Removed helper for getting active cluster selection policy |
| src/views/workflow-summary/config/workflow-summary-details.config.ts | Removed workflow summary fields related to cluster selection policy |
| src/utils/data-formatters/schema/history-event-schema.ts | Added clusterAttribute schema and marked old strategy fields for future removal |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }, | ||
| }, | ||
| }, | ||
| // TODO @adhitya.mamallan: this needs to be removed when regionToCluster is removed from the IDL |
There was a problem hiding this comment.
[nitpick] The TODO comment references removing regionToCluster when it's removed from the IDL. Since this is a fixture for testing, consider adding a note about whether tests should continue to include this empty field for backward compatibility testing, or if it can be removed once the IDL change is complete.
Suggested change
| // TODO @adhitya.mamallan: this needs to be removed when regionToCluster is removed from the IDL | |
| // TODO @adhitya.mamallan: this needs to be removed when regionToCluster is removed from the IDL. | |
| // NOTE: Since this is a fixture for testing, keep this empty field for backward compatibility testing until the IDL change is complete and all relevant tests are updated. It can be removed once the IDL and tests no longer reference it. |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
The field will be removed very soon, so the tests can also stop referencing it (the sooner they do, the better)
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Updated unit tests + ran locally.