Skip to content

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Oct 23, 2025

Summary

  • Add import/named rule to .eslintrc to enable detecting import issues
  • Use deep imports for Lodash
  • Fix other misc lint issues (unused imports/variables)

Test plan

Ran the linter locally.

Signed-off-by: Adhitya Mamallan <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances linting capabilities by enabling the import/named ESLint rule to catch import-related issues. The changes address various lint violations identified after enabling this rule, primarily focusing on converting Lodash imports to deep imports for better tree-shaking and removing unused imports.

Key changes:

  • Added import/named rule to ESLint configuration to detect invalid named imports
  • Converted all Lodash imports from named imports to deep imports (e.g., import { pick } from 'lodash'import pick from 'lodash/pick')
  • Removed unused imports and variables across multiple files

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.eslintrc.js Added import/named rule to enable detection of invalid named imports
src/views/workflow-page/workflow-page-header/workflow-page-header.tsx Removed unused Suspense import
src/views/workflow-history/workflow-history-context-provider/workflow-history-context-provider.types.ts Removed unused type import
src/views/workflow-history/workflow-history-context-provider/workflow-history-context-provider.tsx Removed unused imports (clearLocalStorageValue and type import)
src/views/workflow-actions/workflow-actions.tsx Converted Lodash pick to deep import
src/views/workflow-actions/workflow-actions.styles.ts Removed unused ButtonOverrides type import
src/views/workflow-actions/workflow-action-start-retry-policy/tests/workflow-action-start-retry-policy.test.tsx Converted Lodash get to deep import
src/views/workflow-actions/workflow-action-start-optional-section/tests/workflow-action-start-optional-section.test.tsx Converted Lodash get to deep import
src/views/workflow-actions/workflow-action-start-form/workflow-action-start-form.tsx Converted Lodash get and isObjectLike to deep imports
src/views/domains-page/helpers/get-all-domains.ts Added ESLint disable comment for legitimate cache import from React
src/views/domain-workflows-archival/config/domain-workflows-archival-filters.config.ts Converted Lodash omit to deep import
src/utils/logger/console/register-console-logger.ts Converted Lodash isString to deep import
src/route-handlers/start-workflow/start-workflow.ts Converted Lodash isEmpty to deep import
src/components/multi-select-filter/multi-select-menu/multi-select-menu.tsx Converted Lodash isEqual to deep import
src/components/cron-schedule-input/cron-schedule-input-popover/cron-schedule-input-popover.styles.ts Simplified styled component definition by removing unnecessary function wrapper

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@adhityamamallan adhityamamallan merged commit bee89b2 into cadence-workflow:master Oct 23, 2025
5 checks passed
@adhityamamallan adhityamamallan deleted the fix-lint branch October 23, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants