feat: cluster-attributes - JSON input #7428
Merged
+63
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Porter <[email protected]>
davidporter-id-au
requested review from
3vilhamster,
Shaddoll,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
davidporter-id-au
changed the title
sankari165
reviewed
Nov 12, 2025
| expected types.ActiveClusters | ||
| expectedError error | ||
| }{ | ||
| "valid JSON": { |
Member
There was a problem hiding this comment.
nit: I would expect another test for invalid json
sankari165
reviewed
Nov 12, 2025
tools/cli/domain_commands.go
Outdated
| } | ||
|
|
||
| if !c.IsSet(FlagActiveClusterName) && !c.IsSet(FlagActiveClusters) && !c.IsSet(FlagActiveClustersJSON) { | ||
| return commoncli.Problem("At least one of the flags --active-cluster-name or --active-clusters must be provided.", nil) |
Member
There was a problem hiding this comment.
update message to include the new json option
Member
Author
There was a problem hiding this comment.
oof, these flags are all wrong 🤦
sankari165
approved these changes
Nov 12, 2025
Signed-off-by: David Porter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
it's annoying to manually write a high volume of cluster attributes, so adding via JSON
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes