-
-
Notifications
You must be signed in to change notification settings - Fork 380
controlcenter: many setting panes and minor features #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
modified: config/BarConfig.qml modified: modules/BatteryMonitor.qml modified: modules/background/DesktopClock.qml modified: modules/bar/Bar.qml modified: modules/controlcenter/WindowFactory.qml modified: modules/controlcenter/WindowTitle.qml
new file: modules/bar/components/Settings.qml new file: modules/bar/components/SettingsIcon.qml new file: modules/controlcenter/audio/AudioPane.qml new file: modules/controlcenter/network/Details.qml new file: modules/controlcenter/network/NetworkList.qml new file: modules/controlcenter/network/NetworkPane.qml new file: modules/controlcenter/network/Settings.qml
fix: dependability issues with nmcli
|
look like we have working on the same feature 😀 |
|
I've added a bit more, currently with mind on a mission to have the controlcenter able to manage most aspects of the system. |
|
I’ve done a large refactor to improve overall maintainability, extensibility, and readability. My focus has been on reducing duplicate code and increasing reuse through shared components. This should make future feature development significantly easier. For example, most collapsible sections now use the same component, so updating behavior across them only requires a small change in one place. |
|
@atdma BTW, for the network icons, I actually meant use these for secure networks instead of using literal lock icons
We still want to be able to see the strength in the icon. |
The revision you may have just used I may have had an old version of the wireless network list, I have just put my changes back in there. They don't exactly match what you just described but it is closer. I'll look to use these icons you have provided in the near future. |
|
Also for the wallpaper list you can use a |
|
I can do those tasks, will keep you updated. Thanks for the insight. Could I possibly get some help trying to do the opening and closing animations to match the popout initiated controlcenters? I have tried for hours, many revisions, I cannot get a working animation that works how we would like it. I've gotten close but nothing that I wanted to show off (I also didn't want to commit it unless it matched your animation completely). |
|
Wdym by popout initiated control centres? |
The audio or bluetooth popouts in the tray have buttons to open the controlcenter, they display a nice smooth animation that transitions nicely. |
|
@soramanew All of the items you have brought up have been resolved. Also thanks for the pro-tip on the GridView implementation, that was amazing. I removed my old custom lazy loading code. |
|
Another thing that I noticed is that you are duplicating a lot of stuff that already exists , like for the wallpapers, you can directly use the list from the wallpaper service. You should try looking through the existing components and services to see if they already exist before making a new one. Also, QT has quite a few built in components as well, so you should look through those as well. |
…omponents and consolidated SliderInputs to single component
|
I found 2 areas that I improved with SliderInput (2 almost duplicate components); I've refactored that. The other was StyledInputFields which as also been corrected. These use qt components. I'm curious if you are referencing things such as StyledListView, StyledInputField. These also use qt components but wrap in styling, transition animations, etc. I felt they cleaned up the code a bit and removed a fair chunk of duplicate lines. If you are referencing anything else, please let me know. I'm all ears on what you currently think. |
|
Also after looking into the WallpaperGrid.qml that I am using in the controlcenter wallpaper selector, I can confirm that it is using the service, utilizing the methods Wallpapers.list, Wallpapers.setWallpaper, and Wallpapers.actualCurrent. I removed a manual filename extraction because it already provided a name property, this seems to be using the single source of truth as the wallpaper service. |



I have added the following panels in the controlcenter.
They can continue to be built upon easily, I tried to match the original style that was left in the work in progress panels.
I have also added an icon to the system tray for ethernet connections and a popout for this icon.