background: add support for video wallpapers #908
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: First wallpaper change on shell launch has no transition
Author
|
I just realised that gifs can also be played in MediaOutput, I really dont know the side effects of doing this and if there are any problems, but for now it solves some part of this pr #889 |
AteebXYZ
changed the title
Author
|
Transitions arent FULLY fixed, cant seem to figure out why MediaPlayer emits the media loaded signal even though some frames of black are being displayed in the beginning, also there is a noticeable lag when switching between video to image vice versa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Wallpaper.qml is now modularized into ImageWallpaper.qml and VideoWallpaper.qml, Wallpaper.qml handles the double-buffered switching between these 2 depending on filetype.
filemodel.cpp has been edited to create 2 new filters called "ImagesAndVideos" and "Videos", services/Wallpapers.qml now uses the new "ImagesAndVideos" filter. (note: I suck at any cpp related task so i dont know if i messed something up)
TODO