Export json with id and add 'from_json' func#239
Open
dgercho wants to merge 3 commits intocaesar0301:masterfrom
Open
Export json with id and add 'from_json' func#239dgercho wants to merge 3 commits intocaesar0301:masterfrom
dgercho wants to merge 3 commits intocaesar0301:masterfrom
Conversation
0ab26a7 to
3bd50b8
Compare
3bd50b8 to
72c8f56
Compare
Author
|
@liamlundy @caesar0301 |
04a5df8 to
ea01eb2
Compare
ea01eb2 to
cbbe171
Compare
|
When is this PR going to be integrated? Been half a year and this addition is quite small, but IMO critical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: