Skip to content

Export json with id and add 'from_json' func#239

Open
dgercho wants to merge 3 commits intocaesar0301:masterfrom
dgercho:dev/105-from_json
Open

Export json with id and add 'from_json' func#239
dgercho wants to merge 3 commits intocaesar0301:masterfrom
dgercho:dev/105-from_json

Conversation

@dgercho
Copy link
Copy Markdown

@dgercho dgercho commented Jun 22, 2025

Changes:

  1. Added the node identifier (not presented when exporting to json format).
  2. Added the ability to load a json blob into a 'Tree' structure.
  3. Update the constant json outputs as part of the 'test_shallow_paste'.

@dgercho dgercho requested a review from liamlundy as a code owner June 22, 2025 13:21
@dgercho dgercho force-pushed the dev/105-from_json branch 4 times, most recently from 0ab26a7 to 3bd50b8 Compare June 22, 2025 14:19
@dgercho dgercho force-pushed the dev/105-from_json branch from 3bd50b8 to 72c8f56 Compare June 22, 2025 14:22
@dgercho
Copy link
Copy Markdown
Author

dgercho commented Jul 6, 2025

@liamlundy @caesar0301
Hi, any updates regarding this PR?

@dgercho dgercho force-pushed the dev/105-from_json branch 3 times, most recently from 04a5df8 to ea01eb2 Compare July 6, 2025 14:08
@dgercho dgercho force-pushed the dev/105-from_json branch from ea01eb2 to cbbe171 Compare July 6, 2025 14:10
@cmoliverio
Copy link
Copy Markdown

cmoliverio commented Feb 9, 2026

When is this PR going to be integrated? Been half a year and this addition is quite small, but IMO critical. to_json needs to exist with a from_json counterpart, even if 1.8.0 rolls into 2.0.0 IMO. There is even a duplicate PR (#105) , and another PR that wants to add the identifier to the to_json, #123, so people clearly want this. . . I understand those are relatively easy to implement but this seems like a slam dunk that hasn't been dunking. @liamlundy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants