Skip to content

fix(paypal): throw on API failure and fix collectCard data shape#28514

Closed
nehaaprasad wants to merge 1 commit intocalcom:mainfrom
nehaaprasad:fix/paypl-couldnt-url
Closed

fix(paypal): throw on API failure and fix collectCard data shape#28514
nehaaprasad wants to merge 1 commit intocalcom:mainfrom
nehaaprasad:fix/paypl-couldnt-url

Conversation

@nehaaprasad
Copy link
Contributor

summary

  • Fix PayPal payment URL generation by correcting stored PayPal order data and improving API error handling

Changes

  • Throw when PayPal order creation API fails or returns an invalid response (instead of returning {})
  • Persist HOLD payments as { order: ... } to match the expected frontend data shape (data.order.links)

Test

  • Verified PayPal flow should show the payment button instead of Couldn't obtain payment URL (manual e2e)

fix : #28513

Ctrl+K to generate command

@github-actions github-actions bot added the 🐛 bug Something isn't working label Mar 20, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@anikdhabal
Copy link
Contributor

anikdhabal commented Mar 23, 2026

Thanks for your work @naaa760
#28513 (comment)

@anikdhabal anikdhabal closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PayPal: Couldn't obtain payment URL

2 participants