Skip to content

fix(bookings): apply attendeeEmail filter correctly in v2 bookings #28516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nehaaprasad wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −10
Open

fix(bookings): apply attendeeEmail filter correctly in v2 bookings #28516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions packages/trpc/server/routers/viewer/bookings/get.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,12 +353,17 @@ export async function getBookings({
// 4. Filter by Attendee Name (if provided)
if (filters?.attendeeName) {
if (typeof filters.attendeeName === "string") {
// Simple string match (exact)
fullQuery = fullQuery
.innerJoin("Attendee", "Attendee.bookingId", "Booking.id")
.where("Attendee.name", "=", filters.attendeeName.trim());
const attendeeName = filters.attendeeName.trim();
fullQuery = fullQuery.where((eb) =>
eb.exists(
eb
.selectFrom("Attendee")
.select("Attendee.id")
.whereRef("Attendee.bookingId", "=", "Booking.id")
.where("Attendee.name", "=", attendeeName)
)
);
} else if (isTextFilterValue(filters.attendeeName)) {
// TODO: write makeWhereClause equivalent for kysely
fullQuery = addAdvancedAttendeeWhereClause(
fullQuery,
"name",
Expand All @@ -372,12 +377,17 @@ export async function getBookings({
// 5. Filter by Attendee Email (if provided)
if (filters?.attendeeEmail) {
if (typeof filters.attendeeEmail === "string") {
// Simple string match (exact)
fullQuery = fullQuery
.innerJoin("Attendee", "Attendee.bookingId", "Booking.id")
.where("Attendee.email", "=", filters.attendeeEmail.trim());
const attendeeEmail = filters.attendeeEmail.trim();
fullQuery = fullQuery.where((eb) =>
eb.exists(
eb
.selectFrom("Attendee")
.select("Attendee.id")
.whereRef("Attendee.bookingId", "=", "Booking.id")
.where("Attendee.email", "=", attendeeEmail)
)
);
} else if (isTextFilterValue(filters.attendeeEmail)) {
// TODO: write makeWhereClause equivalent for kysely
fullQuery = addAdvancedAttendeeWhereClause(
fullQuery,
"email",
Expand Down
Loading