fix: correct license check to use data.valid instead of data.status in API v2

[Harshithk951]

What does this PR do?

Fixes #26610

The checkLicense() method in deployments.service.ts was checking
data.status to validate the license key, but the Cal.com license API
returns data.valid (not data.status). This caused all API v2
requests to fail with "Invalid or missing CALCOM_LICENSE_KEY" even
when a valid license key was set.

Visual Demo (For contributors especially)

N/A — single property name fix, no UI changes.

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

1. Set a valid CALCOM_LICENSE_KEY in your environment
2. Make any API v2 request that requires a license check
3. Before fix: request fails with "Invalid or missing CALCOM_LICENSE_KEY"
4. After fix: request succeeds as expected

No new environment variables required.

Checklist

• I have read the contributing guide
• My code follows the style guidelines of this project
• My changes generate no new warnings
• This PR is small (1 file, 3 lines changed)

[cubic-dev-ai]

No issues found across 1 file

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/api/v2/src/modules/deployments/deployments.service.ts">

<violation number="1" location="apps/api/v2/src/modules/deployments/deployments.service.ts:45">
P2: License check fallback is only applied on fresh fetch responses; cached responses still read only `valid`, so legacy cached `{status: true}` payloads bypass the fix.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: License check fallback is only applied on fresh fetch responses; cached responses still read only valid, so legacy cached {status: true} payloads bypass the fix.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/api/v2/src/modules/deployments/deployments.service.ts, line 45:

<comment>License check fallback is only applied on fresh fetch responses; cached responses still read only `valid`, so legacy cached `{status: true}` payloads bypass the fix.</comment>

<file context>
@@ -42,6 +42,6 @@ export class DeploymentsService {
     const cacheKey = getLicenseCacheKey(licenseKey);
     this.redisService.redis.set(cacheKey, JSON.stringify(data), "EX", CACHING_TIME);
-    return data.valid;
+    return data.valid ?? data.status ?? false;
   }
 }
</file context>