fix(bookings): apply attendeeEmail filter correctly#28540
Open
ankitsingh1421 wants to merge 3 commits intocalcom:mainfrom
Open
fix(bookings): apply attendeeEmail filter correctly#28540ankitsingh1421 wants to merge 3 commits intocalcom:mainfrom
ankitsingh1421 wants to merge 3 commits intocalcom:mainfrom
Conversation
|
Singh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Ryukemeister
requested changes
Mar 23, 2026
.claude/settings.json
Outdated
| { | ||
| "env": { | ||
| "CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS": "1" | ||
| }, |
Contributor
There was a problem hiding this comment.
dont think we need these changes can you please revert these
Author
|
Thanks for the suggestions! I've:
Would appreciate another review 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue where the
attendeeEmailquery parameter inGET /v2/bookingswas not applied correctly.Problem
The API was returning all bookings regardless of the provided
attendeeEmailfilter.Solution
attendeeEmailVisual Demo (For contributors especially)
Image Demo (if applicable):
Before Fix:
attendeeEmail)After Fix:
attendeeEmail(Unable to attach screenshots due to local environment issues, but logic has been verified.)
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Setup
CALCOM_API_KEYare setyarn dxTest Steps
Create 3 bookings with different attendee emails:
Call the API:
GET /v2/bookings?take=100&eventTypeId={eventTypeId}&attendeeEmail=attendee-a%40example.com
Expected Result (Happy Path)
totalCountshould be 1attendee-a@example.comshould be returnedPrevious Behavior