fix: validate location URLs using URL constructor in CalEventParser#28548
Draft
NikolaVujovic1988 wants to merge 1 commit intocalcom:mainfrom
Draft
fix: validate location URLs using URL constructor in CalEventParser#28548NikolaVujovic1988 wants to merge 1 commit intocalcom:mainfrom
NikolaVujovic1988 wants to merge 1 commit intocalcom:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/^https?:\/\//) with properURLconstructor validation ingetProviderNamepackages/libmust not import from@calcom/app-storeper architecture rulesContext
Addresses review feedback from #28242, where @romitg2 requested using an existing library/function for URL validation rather than simply removing the comment.
The
URLconstructor is already used for validation elsewhere inpackages/lib(e.g.,getSafeRedirectUrl.ts) and requires no additional dependencies.Test plan
yarn type-check:ci --forcepasses