fix: issue when uncontrolled input value is set programmatically i.e … #4600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without typing We have a use case which I feel is very common. We have remark suggestions for an entry. Once suggestion is picked and value is set using setNativeProps method uncontrolledValue is not updated this is resulting input label and palceholder to get overlapped.
|
Hey @shubhamdeol, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
shubhamdeol
changed the title
lukewalczak
force-pushed
the
main
branch
6 times, most recently
from
1062366 to
1da5d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…without typing
Motivation
We have a use case which I feel is very common. We have remark suggestions for an entry. Once suggestion is chosen from list of suggestions and value is set using setNativeProps method, uncontrolledValue is not updated this is resulting input label and palceholder to get overlapped.
This can also happen in cases where pastes the content into input without typing it.
Related issue
Screenshots
Test plan