Skip to content

fix: fix render hook typing #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2025
Merged

fix: fix render hook typing #1811

merged 5 commits into from
Aug 20, 2025

Conversation

mdjastrzebski
Copy link
Member

Summary

Fixes #1810

Test plan

Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.94%. Comparing base (e5fa23c) to head (7e5aeb1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/types.ts 0.00% 4 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (58.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
- Coverage   90.10%   89.94%   -0.17%     
==========================================
  Files          98       98              
  Lines        5852     5856       +4     
  Branches      945      605     -340     
==========================================
- Hits         5273     5267       -6     
- Misses        574      584      +10     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdjastrzebski mdjastrzebski force-pushed the fix/render-hook-typing branch from 5a1e696 to 3962c4c Compare August 20, 2025 07:02
@mdjastrzebski mdjastrzebski merged commit 97280b0 into main Aug 20, 2025
6 of 7 checks passed
@mdjastrzebski mdjastrzebski deleted the fix/render-hook-typing branch August 20, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'result.current' is possibly 'null' type error
1 participant