fix: Do not infer generic Props type from RenderHookOptions #1816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unsure when this happened, but noticed it when bumping a react-native project to 0.80.1. (Using typescript 5.5.4)
renderHook
andrenderHookAsync
should not inferProps
fromRenderHookOptions
.See the following example:
This is resulting in optional props not specified in the initialProps setting to type-error when using
rerender()
.This is because the
Props
generic type is being inferred from bothExampleProps
and{ required: string, unknown: number }
due to it appearing also in initialProps.This is addressed by wrapping it with
NoInfer<>
so that the options are ignored for inferringProps
Test plan
After the fix is applied, the type-errors are correctly pointing out that
unknown
is not a prop.