-
Notifications
You must be signed in to change notification settings - Fork 31
WIP feat: allow running dev server from run commands #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
logger.info('Starting dev server...'); | ||
startDevServer({ | ||
root: projectRoot, | ||
reactNativePath: './node_modules/react-native', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this won't work in more complex setups, needs params (but it's temporary, right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah
83e802f
to
5da0615
Compare
oops looke like the nx cache got in there |
92bc2df
to
e6a0b55
Compare
Yeah, not sure how to remove it. I don't see those changes in my commits |
|
fe01603
to
07e04e4
Compare
07e04e4
to
2da44ea
Compare
@OlimpiaZurek can you link some video recordings from this feature in action? Could you please describe your UX concerns from our sync? Thanks! |
Summary
While running
run:android
orrun:ios
we should be able to start a dev server and keep it open after the build is doneTest plan