[Fix] Improve validation for service parameters in MtaTransformer and correct error logging in util

[anirudhprasad-sap]

Fix Validation Logic and Error Handling in MTA Processing

🐛 Bug Fix: Corrected critical validation logic errors and enhanced service parameter validation to prevent runtime crashes when processing MTA configurations.

Changes

• bin/cap-op-plugin.js: Fixed inverted boolean logic in YAML path existence validation that was causing the validator to reject valid files and accept missing ones. The condition now properly checks if a path exists before proceeding with both --with-input-yaml and --with-runtime-yaml options.

• lib/mta-transformer.js: Significantly improved the getServiceInstances() method's robustness by:

  • Adding validation for missing parameters object before attempting property access
  • Implementing early-exit logic with user-friendly warning messages when required service or service-plan parameters are absent
  • Extracting service offering and plan values into variables for cleaner code and to avoid repeated null checks
  • Removing redundant ternary operations that were already handled by the validation logic
  • Preventing potential Cannot read property 'service' of undefined errors

• lib/util.js: Corrected error variable reference in the extractAndReplaceHanaInstanceId() function from error.message to err.message to match the actual catch block parameter name.

These fixes prevent application crashes when processing incomplete MTA configurations and ensure file validation behaves as intended, improving overall system stability.

• 🔄 Regenerate and Update Summary

---

📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

PR Bot Information

Version: 1.17.69 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

• Correlation ID: cde1c050-1186-11f1-952b-4d9774184afd
• Event Trigger: pull_request.edited
• Summary Prompt: Default Prompt
• LLM: anthropic--claude-4.5-sonnet
• Output Template: Default Template

[hyperspace-insights]

All changes have been reviewed. The pull request addresses several important fixes:

1. bin/cap-op-plugin.js - Fixed logic error where the condition was checking !yamlPath instead of yamlPath before path existence check (lines 39, 49)
2. lib/util.js - Fixed variable name typo from error.message to err.message (line 140)
3. lib/mta-transformer.js - Added validation for missing service parameters before accessing them (lines 104-116)

The logic fixes are solid and prevent potential runtime errors. I identified one minor naming improvement opportunity where the variable service could be more descriptive.

PR Bot Information

Version: 1.17.61 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

• LLM: anthropic--claude-4.5-sonnet
• Correlation ID: 09244d70-1161-11f1-9ab1-025508631202
• Event Trigger: pull_request.opened

[sonarqubecloud]

Quality Gate failed

Failed conditions
71.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud