Update read/written registers for x87 comparison instructions #2784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been part of capstone-engine#2680
Rot127
requested changes
Sep 11, 2025
There is now one test case for each operand input for each opcode (e.g., DE/2 and DE/3).
hainest
force-pushed
the
thaines/x87_comp
branch
from
a8deea7 to
a5a2783
Compare
Rot127
requested changes
Sep 14, 2025
Rot127
approved these changes
Sep 15, 2025
|
@Rot127 Sorry about the late changes. I try not to do updates after a PR has been approved, but I discovered today that Chapter 5 of the SDM has a nice listing of all of the instructions broken down by category where I found |
Rot127
approved these changes
Sep 18, 2025
Comment on lines
+2459
to
+2460
| 0xd9, 0xe4, # ftest | ||
| 0xd9, 0xe5 # fxam |
There was a problem hiding this comment.
Just as advice. It is usually a little easier if the instructions are in a separated test case.
The cstest output currently doesn't report which instruction failed.
So if the instructions don't depend on each other, having them separated is simpler to debug..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been part of #2680
Your checklist for this pull request
Detailed description
These are updates to the x87 comparison instructions that includes more detail on segment registers and FPU flags. It also fixes bugs introduced in #2680 that incorrectly removed FPU flag modifications from the
fcomifamily of instructions. Testing is substantially expanded....
Test plan
Tests are included.