-
Notifications
You must be signed in to change notification settings - Fork 153
fix(notificationsPanel): nested interactive controls #7939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7939 +/- ##
==========================================
+ Coverage 79.38% 83.94% +4.56%
==========================================
Files 474 356 -118
Lines 20340 17000 -3340
Branches 5006 4036 -970
==========================================
- Hits 16146 14271 -1875
+ Misses 4194 2729 -1465
🚀 New features to boost your workflow:
|
packages/ibm-products-styles/src/components/NotificationsPanel/_notifications-panel.scss
Outdated
Show resolved
Hide resolved
Hey @szinta, looks like avt tests are failing for Notification panel. Can you take a look? |
Closes #7612
nested interactive controls
accessibility violation in NotificationsPanel web componentnested interactive controls
accessibility violation in NotificationsPanel React componentHow did you test and verify your work?
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request section of
our contributing docs.