Skip to content

Conversation

szinta
Copy link
Contributor

@szinta szinta commented Jul 30, 2025

Closes #7612

  • fixes nested interactive controls accessibility violation in NotificationsPanel web component
  • partially fixes nested interactive controls accessibility violation in NotificationsPanel React component
  • adds accessibility unit tests in both versions ( new tests are commented now as it is throwing error)

How did you test and verify your work?

  • Storybook
  • Unit tests
  • IBM accessibility checker

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request section of
our contributing docs.

@szinta szinta requested a review from a team as a code owner July 30, 2025 11:27
@szinta szinta requested review from anamikaanu96 and matthewgallo and removed request for a team July 30, 2025 11:27
Copy link

netlify bot commented Jul 30, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 9f07365
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/68cd60f6e6a2a80008cd8897
😎 Deploy Preview https://deploy-preview-7939--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 30, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 9f07365
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/68cd60f60c90f200087abae8
😎 Deploy Preview https://deploy-preview-7939--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.94%. Comparing base (1c4fa62) to head (9f07365).
⚠️ Report is 131 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7939      +/-   ##
==========================================
+ Coverage   79.38%   83.94%   +4.56%     
==========================================
  Files         474      356     -118     
  Lines       20340    17000    -3340     
  Branches     5006     4036     -970     
==========================================
- Hits        16146    14271    -1875     
+ Misses       4194     2729    -1465     
Components Coverage Δ
ibm-products 81.48% <77.29%> (+0.90%) ⬆️
ibm-products-web-components 87.75% <70.45%> (+11.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szinta szinta changed the title fix(notificationPanel): nested interactive controls fix(notificationsPanel): nested interactive controls Aug 5, 2025
@szinta szinta added the status: WIP work in progress label Aug 12, 2025
@szinta szinta removed the status: WIP work in progress label Aug 13, 2025
@szinta szinta requested a review from matthewgallo August 13, 2025 13:05
@anamikaanu96
Copy link
Contributor

Hey @szinta, looks like avt tests are failing for Notification panel. Can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y]: NotificationPanel: Ensure interactive controls are not nested

3 participants