- 
                Notifications
    
You must be signed in to change notification settings  - Fork 154
 
          feat(build): adopt tsdown for builds
          #8065
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            matthewgallo
  wants to merge
  21
  commits into
  carbon-design-system:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
matthewgallo:8024-adopt-tsdown-for-build
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            
  
    feat(build): adopt tsdown for builds
  
  #8065
              
                    matthewgallo
  wants to merge
  21
  commits into
  carbon-design-system:main
from
matthewgallo:8024-adopt-tsdown-for-build
  
      
      
   
              
            
      
        
          +1,679
        
        
          −760
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …llo/ibm-products into 7953-rolldown-vite-integration
          ✅ Deploy Preview for ibm-products-web-components ready!
 To edit notification comments on pull requests, go to your Netlify project configuration.  | 
    
          ✅ Deploy Preview for carbon-for-ibm-products ready!
 To edit notification comments on pull requests, go to your Netlify project configuration.  | 
    
          Codecov Report❌ Patch coverage is  Additional details and impacted files@@            Coverage Diff             @@
##             main    #8065      +/-   ##
==========================================
- Coverage   79.38%   79.21%   -0.17%     
==========================================
  Files         474      475       +1     
  Lines       20340    20517     +177     
  Branches     5006     5024      +18     
==========================================
+ Hits        16146    16253     +107     
- Misses       4194     4264      +70     
 🚀 New features to boost your workflow:
  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Closes #8024
📢 This branches off #7956 which should be reviewed and merged before this PR
This replaces our rollup build setup with
tsdownfor both react and web components. There was a noticeable improvement in the react build times (~25 seconds down to ~3.5 seconds). The web component package requires some sass transformation in order to map the sass files into lit templates which usessass.renderwhich is very slow and also deprecated. If we could find a faster alternative tosass.renderthe web components package would likely see stronger improvements.What did you change?
How did you test and verify your work?
Manually ran builds for both react and web component packages
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request section of
our contributing docs.