Skip to content

Conversation

anamikaanu96
Copy link
Contributor

Closes #8137

Implemented Coachmark Stacked as patterns

What did you change? Add new folder in packages/ibm-products/src/patterns for CoachmarkStacked and added its related files.

How did you test and verify your work? yarn storybook

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request section of
our contributing docs.

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner September 25, 2025 11:23
@anamikaanu96 anamikaanu96 requested review from davidmenendez and szinta and removed request for a team September 25, 2025 11:23
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 4751622
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/68e76adf81ce410008a007a8
😎 Deploy Preview https://deploy-preview-8317--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 4751622
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/68e76ade10cdcb00084f074f
😎 Deploy Preview https://deploy-preview-8317--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@anamikaanu96 anamikaanu96 changed the title Coachmark stacked feat(coachmarkStacked): implemented as patterns Sep 25, 2025
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.39%. Comparing base (1c4fa62) to head (4751622).
⚠️ Report is 179 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8317      +/-   ##
==========================================
+ Coverage   79.38%   85.39%   +6.01%     
==========================================
  Files         474      373     -101     
  Lines       20340    17379    -2961     
  Branches     5006     4078     -928     
==========================================
- Hits        16146    14841    -1305     
+ Misses       4194     2538    -1656     
Components Coverage Δ
ibm-products 83.43% <100.00%> (+2.85%) ⬆️
ibm-products-web-components 88.25% <82.29%> (+11.53%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the wait! looks great, just one small comment

Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I caught was that when you open a "stack" with multiple coachmarks, clicking on the close icon closes all of the coachmarks currently open in the stack. In the previous implementation, it just closes the one that is visible. I think it's fine to re-visit this but we should match the previous behavior.

@anamikaanu96
Copy link
Contributor Author

One thing that I caught was that when you open a "stack" with multiple coachmarks, clicking on the close icon closes all of the coachmarks currently open in the stack. In the previous implementation, it just closes the one that is visible. I think it's fine to re-visit this but we should match the previous behavior.

@matthewgallo That looks like a bug. I can open a separate issue for it if that’s okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CoachmarkStacked as patterns
3 participants