-
Notifications
You must be signed in to change notification settings - Fork 153
feat(coachmarkStacked): implemented as patterns #8317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(coachmarkStacked): implemented as patterns #8317
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8317 +/- ##
==========================================
+ Coverage 79.38% 85.39% +6.01%
==========================================
Files 474 373 -101
Lines 20340 17379 -2961
Branches 5006 4078 -928
==========================================
- Hits 16146 14841 -1305
+ Misses 4194 2538 -1656
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the wait! looks great, just one small comment
packages/ibm-products/src/patterns/CoachmarkStacked/CoachmarkStacked.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that I caught was that when you open a "stack" with multiple coachmarks, clicking on the close icon closes all of the coachmarks currently open in the stack. In the previous implementation, it just closes the one that is visible. I think it's fine to re-visit this but we should match the previous behavior.
@matthewgallo That looks like a bug. I can open a separate issue for it if that’s okay? |
Closes #8137
Implemented Coachmark Stacked as patterns
What did you change? Add new folder in packages/ibm-products/src/patterns for
CoachmarkStacked
and added its related files.How did you test and verify your work? yarn storybook
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request section of
our contributing docs.