chore(ci): do not update playwright reports for drafts #8404
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewgallo
changed the title
matthewgallo
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8404 +/- ##
==========================================
+ Coverage 79.38% 85.44% +6.06%
==========================================
Files 474 371 -103
Lines 20340 17367 -2973
Branches 5006 4075 -931
==========================================
- Hits 16146 14840 -1306
+ Misses 4194 2527 -1667
🚀 New features to boost your workflow:
|
matthewgallo
requested review from
anamikaanu96 and
szinta
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a PR over in core that fixes this so thought I'd bring the change over here for our ci workflow. This will opt-out of updating the playwright coverage reports for draft PRs.
What did you change?
.github/workflows/ci.ymlHow did you test and verify your work?
Will verify in this PR, I'll open initially as a draft
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request section of
our contributing docs.