Ensure a symbolic final impl has a definition produced
#6236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
force-pushed
the
lower-crash
branch
2 times, most recently
from
992322b to
f0f19d5
Compare
geoffromer
reviewed
Nov 25, 2025
Contributor
geoffromer
left a comment
geoffromer
left a comment
There was a problem hiding this comment.
(I haven't reviewed all the testdata yet)
|
|
||
| auto EvalConstantInst(Context& context, SemIR::RequireSpecificDefinition inst) | ||
| -> ConstantEvalResult { | ||
| ResolveSpecificDefinition(context, SemIR::LocId::None, inst.specific_id); |
Contributor
There was a problem hiding this comment.
This returns false on failure, right? Should we CHECK it?
| // TIP: To dump output, run: | ||
| // TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/array/bound_values.carbon | ||
|
|
||
| // TODO |
Contributor
There was a problem hiding this comment.
I'm guessing this is a case of a deleted file getting accidentally restored by the merge-then-autoupdate workflow?
| // CHECK:STDOUT: !definition: | ||
| // CHECK:STDOUT: <elided> | ||
| // CHECK:STDOUT: %Class.elem: type = unbound_element_type %Class, %T.binding.as_type [symbolic = %Class.elem (constants.%Class.elem.bc9)] | ||
| // CHECK:STDOUT: %.loc15_12.2: require_specific_def_type = require_specific_def @ptr.as.Copy.impl(%T.binding.as_type) [symbolic = %.loc15_12.2 (constants.%.d8a)] |
Contributor
There was a problem hiding this comment.
The comment in impl_lookup.cpp says this is used when the impl is final, but I'm having trouble working out what final impl this is referring to. Am I misunderstanding something?
Contributor
There was a problem hiding this comment.
Another restored _addr test, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the impl lookup can both fail to resolve the specific definition because it's symbolic, and return a "final" constant because it's a
final impl. This is adding an instruction to help ensure the specific is resolved.The constant evaluation is fully recursive, but I'm not adding a TODO since that's a known issue with impl lookup in general.