Repository navigation
fix: match-ref bug - #1611
Draft
eriksvedang wants to merge 2 commits into
Draft
fix: match-ref bug#1611eriksvedang wants to merge 2 commits into
match-ref bug#1611eriksvedang wants to merge 2 commits into
Conversation
hellerve
reviewed
Oct 25, 2026
Comment on lines
+136
to
+137
| mkExprConstr x@(XObj (Sym _symPath _symMode) _ (Just t)) = | ||
| Just (Constraint (wrapInRefTyIfMatchRef matchMode t) (wrapInRefTyIfMatchRef matchMode exprType) x expr xobj OrdArg) |
Member
There was a problem hiding this comment.
i think this drops the check that the matched expression of a match-ref is a ref. before, Ref t ~ exprType forced exprType to be a ref.
now i can just (defn r [] (match-ref (Maybe.Just @"leak") _ 1)), have it compile, and it’ll leak.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I solved this bug using my gut, need to think a bit more about it before it goes in :)
(and I'll add regression tests)
Closes #1610.