Skip to content

Conversation

@rogeruiz
Copy link
Member

@rogeruiz rogeruiz commented Mar 24, 2025

  1. 💬 Create the first draft for resetting theme 🏷️ b4c3472

Important

More updates coming soon as progress is made. Watch this space for updates
soon.

This work is based on the work in #500. Until that PR is merged,
this patch will remain a draft.

@rogeruiz rogeruiz added the documentation Improvements or additions to documentation label Mar 24, 2025
@rogeruiz rogeruiz self-assigned this Mar 24, 2025
@rogeruiz rogeruiz changed the base branch from main to lightdark March 24, 2025 02:35
@rogeruiz rogeruiz marked this pull request as draft March 24, 2025 02:35
@kjnsn
Copy link
Collaborator

kjnsn commented Mar 30, 2025

Wow thanks so much for writing all this up! It's awesome!

I don't think that the tmux change to use CSI 2031 (where the terminal reports a light/dark mode change) is required for users to benefit from the reset option. I'd also be really happy to get some more docs that explain how options work in a way that is immediately relevant for us.

So I would like to merge this into a feature branch where we can collaborate on this in smaller chunks, and also give others the opportunity to work on the draft docs. Once we're happy enough we can merge into main.

Separately, I'll create a draft PR that adds documentation regarding tmux's light/dark theme hooks. That can be merged when tmux creates a new release.

@kjnsn kjnsn marked this pull request as ready for review March 30, 2025 03:48
@kjnsn kjnsn merged commit 22b32d8 into lightdark Mar 30, 2025
2 checks passed
@kjnsn kjnsn deleted the rogeruiz/docs/lightdark branch March 30, 2025 03:48
@rogeruiz
Copy link
Member Author

🎉 yay! Thanks. I agree on the feature branch work. The docs we have so far are great. Happy to add to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants