-
-
Notifications
You must be signed in to change notification settings - Fork 968
feat(transport): add valkey and valkeys #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for referencing that. So this is a blocker and it probably needs a new Valkey transport implementation in kombu? We recently switched from Redis to Valkey and didn't experience any issues with celery. It works as before. |
I don't recall all of the details, but the other issue explains where we are right now. |
I think we might be able to use same code for two differently named backend named redis / valkey / dragonfly etc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this makes most sense as we do not need to maintain double code for the same back end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just adding docs and may be should be OK for now
any updates on this @Zerotask ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Valkey transport schemes (valkey
and valkeys
) as alternative connection protocols to the existing Redis transport, since Valkey is an open-source drop-in replacement for Redis.
- Adds Valkey transport scheme mappings to use the existing Redis transport implementation
- Updates documentation to include Valkey connection examples and transport comparison entries
- Adds Valkey references to README keywords and features sections
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
kombu/transport/init.py | Maps valkey/valkeys schemes to Redis transport |
kombu/transport/redis.py | Adds Valkey connection string documentation |
docs/userguide/connections.rst | Adds Valkey URL example and transport comparison entry |
README.rst | Updates keywords and features to mention Valkey support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
This PR adds the alternative transport schemes
valkey
andvalkeys
, which is also the recommendation fromdjango-valkey
.Fixes #2245
I didn't update the documentation because I first want to get feedback.
There could be a new page for Valkey or just an addition for the Redis transport here:
https://docs.celeryq.dev/projects/kombu/en/stable/reference/kombu.transport.redis.html
Valkey is an open source drop-in replacement for Redis:
https://django-valkey.readthedocs.io/en/latest/configure/advanced_configurations.html