Skip to content

Conversation

Zerotask
Copy link

@Zerotask Zerotask commented Feb 18, 2025

This PR adds the alternative transport schemes valkey and valkeys, which is also the recommendation from django-valkey.

Fixes #2245

I didn't update the documentation because I first want to get feedback.
There could be a new page for Valkey or just an addition for the Redis transport here:
https://docs.celeryq.dev/projects/kombu/en/stable/reference/kombu.transport.redis.html


Valkey is an open source drop-in replacement for Redis:

This project was forked from the open source Redis project right before the transition to their new source available licenses.
(https://github.com/valkey-io/valkey)

https://django-valkey.readthedocs.io/en/latest/configure/advanced_configurations.html

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zerotask
Copy link
Author

See celery/celery#9300

Thank you for referencing that. So this is a blocker and it probably needs a new Valkey transport implementation in kombu?

We recently switched from Redis to Valkey and didn't experience any issues with celery. It works as before.

@Nusnus
Copy link
Member

Nusnus commented Feb 18, 2025

See celery/celery#9300

Thank you for referencing that. So this is a blocker and it probably needs a new Valkey transport implementation in kombu?

We recently switched from Redis to Valkey and didn't experience any issues with celery. It works as before.

I don't recall all of the details, but the other issue explains where we are right now.

@auvipy
Copy link
Member

auvipy commented May 20, 2025

I think we might be able to use same code for two differently named backend named redis / valkey / dragonfly etc

@auvipy auvipy self-requested a review May 20, 2025 09:20
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this makes most sense as we do not need to maintain double code for the same back end

@auvipy auvipy added this to the 5.7.0 milestone Jun 1, 2025
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding docs and may be should be OK for now

@flipsed
Copy link

flipsed commented Sep 23, 2025

any updates on this @Zerotask ?

@Zerotask
Copy link
Author

just adding docs and may be should be OK for now

Since there might be a standalone backend in the future, I just added very basic docs, so people will know about this.
Is this okay or is there anything specific missing? @auvipy @Nusnus

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Valkey transport schemes (valkey and valkeys) as alternative connection protocols to the existing Redis transport, since Valkey is an open-source drop-in replacement for Redis.

  • Adds Valkey transport scheme mappings to use the existing Redis transport implementation
  • Updates documentation to include Valkey connection examples and transport comparison entries
  • Adds Valkey references to README keywords and features sections

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
kombu/transport/init.py Maps valkey/valkeys schemes to Redis transport
kombu/transport/redis.py Adds Valkey connection string documentation
docs/userguide/connections.rst Adds Valkey URL example and transport comparison entry
README.rst Updates keywords and features to mention Valkey support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Valkey
4 participants